Admin & Ordering Fixes

Overview

A cluster of targeted fixes across the admin and ordering portals: draft order notes stopped firing emails, DA/BP email automation handles edge cases in order creation, invoice saves no longer fail on extra fields, and title prediction days became env-configurable.

What Changed

Draft Order Email Guards (v3.6.1, PR #798)

• ProjectOrderNoteListener now skips email dispatch for notes with draft/pending status.
• Customers stopped receiving spurious notifications for notes their staff hadn't finalised yet.

DA/BP Email Automation (v3.6.2)

• DAEmailHandler and EmailHandler hardened against missing fields and edge-case ordering events when creating orders from automation emails.
• Order notification regressions introduced during earlier refactors were resolved.
• Order note titles now appear in customer notification emails.

Invoice Form "Extra Fields" Error

• Some invoice saves were failing with a Symfony "extra fields" validation error due to stale form fields in the rendered HTML.
• Form definition tightened to match the active fieldset.

Title Prediction Days

• TITLE_PREDICTION_DAYS environment variable with a 28-day default.
• Per-estate overrides land in release 3.7 (estate.titlePredictionDays).

Sale Check PDF Accuracy

• Sale Check PDF export previously rendered the last-saved state, not the on-screen form state.
• Fixed so PDF reflects the current form.

PO Number on Project Edit

• PO Number field exposed on the admin project edit form.
• Note: This was later removed in v3.7.2 after a decision that PO numbers belong only on the ProjectInvoice entity, not on Project. See the release 3.7 entry.

Session-Backed Auth for Ordering API

• Restored session-backed authentication for ordering API routes that were incorrectly requiring token auth.

Vendor Field Optional (Admin Project Orders)

• Admin project orders no longer require a vendor on save; some workflows legitimately don't know the vendor yet.

Changelog Reference

• fix: Sale Check PDF now reflects current on-screen form data (74ee3d4)
• fix: resolve invoice form 'extra fields' error (cccfe62)
• fix: make title prediction days configurable via env var (0a0f8f3)
• fix: expose PO Number field in admin project edit form (527f8a0)
• fix: prevent duplicate estate RFI items on project sync (e777316)
• fix: restore session-backed auth for ordering API routes (a3c0196)
• fix: allow DA email relabeling on all environments (4a6a8be)
• Prevent order note emails for draft/pending notes (v3.6.1)
• fix: improve DA/BP email automation order creation (v3.6.2)
• Fix project order note notification regressions (v3.6.2)
• Use order note titles in customer notification emails (v3.6.2)